Skip to content

🎨 Adding tracing to agent and dynamic-sidecar (🏗️ DEVOPS) #6691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 14, 2024
Merged

🎨 Adding tracing to agent and dynamic-sidecar (🏗️ DEVOPS) #6691

merged 12 commits into from
Nov 14, 2024

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 8, 2024 •
edited
Loading

What do these changes do?

  • Adds tracing to agent service
  • Adds tracing to dynamic-sidecar this is inherited from the director-v2 tracing options. If tracing is enabled on director-v2 it will also enable it on all dynamic-sidecars

DEVOPS Tasks

  • Make PR that adds opentelemetry-collector to the interactive services subnet on all deployments (to make dy-sidecar talk to openetelemetry-collector)

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK added the t:maintenance Some planned maintenance work label Nov 8, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 8, 2024
@GitHK GitHK self-assigned this Nov 8, 2024
@codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.32%. Comparing base (0781e63) to head (b2e0b38).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (0781e63) and HEAD (b2e0b38). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (0781e63) HEAD (b2e0b38)
unittests 30 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #6691       +/-   ##
===========================================
- Coverage   87.46%   65.32%   -22.14%     
===========================================
  Files        1533      633      -900     
  Lines       61179    31482    -29697     
  Branches     2119      265     -1854     
===========================================
- Hits        53509    20566    -32943     
- Misses       7344    10855     +3511     
+ Partials      326       61      -265
Flag Coverage Δ *Carryforward flag
integrationtests 64.85% <ø> (-0.01%) ⬇️ Carriedforward from a44de5c
unittests 96.98% <80.00%> (+11.63%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent 96.98% <80.00%> (-0.19%) ⬇️
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.42% <ø> (-14.34%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.79% <ø> (-30.01%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.79% <ø> (-28.92%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0781e63...b2e0b38. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review November 8, 2024 11:56
GitHK
GitHK commented Nov 8, 2024
View reviewed changes
mrnicegyu11
mrnicegyu11 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks a lot!

@mrnicegyu11 mrnicegyu11 changed the title 🎨 Adding tracing to agent and dynamic-sidecar 🎨 Adding tracing to agent and dynamic-sidecar (🏗️ DEVOPS) Nov 8, 2024
YuryHrytsuk
YuryHrytsuk reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for OPS PR.

@mrnicegyu11 is preparing OPS changes

@mrnicegyu11 mrnicegyu11 mentioned this pull request Nov 13, 2024
Merged
1 task
@mrnicegyu11
Copy link
Member

mrnicegyu11 commented Nov 13, 2024

this should do the trick @GitHK @YuryHrytsuk ITISFoundation/osparc-ops-environments#872

mrnicegyu11 added a commit to ITISFoundation/osparc-ops-environments that referenced this pull request Nov 13, 2024
@mrnicegyu11
Sister PR for ITISFoundation/osparc-simcore#6691 (#872)
3a0e944 
* wip

* Add csi-s3 and have portainer use it

* Change request @Hrytsuk 1GB max portainer volume size

* Sister PR6691

---------

Co-authored-by: Dustin Kaiser <[email protected]>
@GitHK
Copy link
Contributor Author

GitHK commented Nov 14, 2024

this should do the trick @GitHK @YuryHrytsuk ITISFoundation/osparc-ops-environments#872

Thanks a lot, will go ahead and merge now

@GitHK GitHK enabled auto-merge (squash) November 14, 2024 11:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK GitHK merged commit 9e6ca99 into ITISFoundation:master Nov 14, 2024
82 of 89 checks passed
@GitHK GitHK deleted the pr-osparc-connect-opentelemetry-to-missing-services branch November 14, 2024 13:08
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 26, 2024
Closed
18 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuryHrytsuk YuryHrytsuk YuryHrytsuk left review comments

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@GitHK GitHK

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

6 participants

@GitHK @mrnicegyu11 @pcrespov @sanderegg @YuryHrytsuk @matusdrobuliak66